Restrict supported service types of Karamda APIServer supported by karmada-operator #5769
Conversation
…karmada-operator. Signed-off-by: RainbowMango <[email protected]>
karmada-bot
added
kind/cleanup
karmada-bot
added
the
size/M
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #5769 +/- ##
==========================================
+ Coverage 42.31% 42.32% +0.01%
==========================================
Files 655 655
Lines 55756 55756
==========================================
+ Hits 23591 23598 +7
+ Misses 30651 30646 -5
+ Partials 1514 1512 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
/lgtm |
RainbowMango
added
the
approved
|
[APPROVALNOTIFIER] This PR is APPROVED Approval requirements bypassed by manually added approval. This pull-request has been approved by: The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind cleanup
/kind api-change
What this PR does / why we need it:
This PR restrics the service types supported by karmada-operator.
Which issue(s) this PR fixes:
Part of #5767
Special notes for your reviewer:
This PR introduces validation rules which narrow down the range of acceptable configuration, but this has no impact on users who are currently using
ClusterIPandNodePort. And forLoadbalancerandExternalName, currently not supported. (We are considering introduce the support ofLoadbalancerto address the use case reported at #4634).Does this PR introduce a user-facing change?: